Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove snake yml #17170

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: remove snake yml #17170

wants to merge 4 commits into from

Conversation

lpetrovic05
Copy link
Member

@lpetrovic05 lpetrovic05 commented Dec 26, 2024 •
edited
Loading

closes #17134

  • the ticket mentions PBJ, which currently does not work when needing to parse a file into a custom record. this could potentially be implemented in the future, but for now, it cannot be consolidated.
  • snakeyaml was removed from production code, we now only rely on jackson. snakeyaml is still present in the test clients code, but I see no need to change that (and have no knowledge about the test clients)
  • the change to jackson allows us to trivially support JSON config files
  • a bug was found while working on this and a ticket was opened for it: Fix config YAML file parsing issue #17173

@lpetrovic05
remove snake from config dep
80bafd3 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
cleanup
900a71f 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
s
94314b9 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
comment
f7b2fbd 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 added this to the v0.59 milestone Dec 26, 2024
@lpetrovic05 lpetrovic05 self-assigned this Dec 26, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.29%. Comparing base (fe64ed3) to head (f7b2fbd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ds/config/extensions/sources/YamlConfigSource.java 85.71% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17170   +/-   ##
=========================================
  Coverage     64.29%   64.29%           
+ Complexity    20905    20899    -6     
=========================================
  Files          2552     2552           
  Lines         96035    96025   -10     
  Branches      10047    10046    -1     
=========================================
- Hits          61741    61738    -3     
+ Misses        30664    30658    -6     
+ Partials       3630     3629    -1
Files with missing lines Coverage Δ
...ds/config/extensions/sources/YamlConfigSource.java 81.94% <85.71%> (+9.99%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% (target: -1.00%) ✅ 85.71%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fe64ed3) 95798 65180 68.04%
Head commit (f7b2fbd) 95788 (-10) 65176 (-4) 68.04% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17170) 28 24 85.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@lpetrovic05 lpetrovic05 marked this pull request as ready for review December 27, 2024 10:48
@lpetrovic05 lpetrovic05 requested review from a team as code owners December 27, 2024 10:48
andrewb1269hg
andrewb1269hg approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed file hiero-dependency-versions/build.gradle.kts and approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewb1269hg andrewb1269hg andrewb1269hg approved these changes

@rbarkerSL rbarkerSL Awaiting requested review from rbarkerSL rbarkerSL is a code owner automatically assigned from hashgraph/devops-ci

@timo0 timo0 Awaiting requested review from timo0 timo0 is a code owner automatically assigned from hashgraph/platform-hashgraph

At least 1 approving review is required to merge this pull request.

Assignees

@lpetrovic05 lpetrovic05

Labels
None yet
Projects
None yet
Milestone
v0.59
Development

Successfully merging this pull request may close these issues.

Consolidate usage for Object Serializer
2 participants
@lpetrovic05 @andrewb1269hg